Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate the Arrows with Navigational Groups #279

Closed
pablohoneyhoney opened this issue Sep 19, 2022 · 6 comments
Closed

Associate the Arrows with Navigational Groups #279

pablohoneyhoney opened this issue Sep 19, 2022 · 6 comments

Comments

@pablohoneyhoney
Copy link

The arrow should be closer to the navigational instance it’s associated to. Currently they are at an uncanny distance that creates a scattered visual effect, but also doesn't make the taxonomies clear.

Screen Shot 2022-09-19 at 11 30 20 AM

Screen Shot 2022-09-19 at 11 30 12 AM

@jasmussen
Copy link
Collaborator

jasmussen commented Sep 19, 2022

I would agree! It looks separate at this point. Something like this, maybe?

Screenshot 2022-09-19 at 11 36 02

In this mockup, I also moved the arrow slightly downwards to optically balance with the text.

@ryelle
Copy link
Contributor

ryelle commented Sep 19, 2022

We talked about this a little in #263 & #261 — the arrows need to have enough space to be touch targets (illustrated here with the focus state).

Screen Shot 2022-09-19 at 10 44 42 AM

The right side of the text already has a less spacing than the left, so I don't think we can shift that any more.

Screen Shot 2022-09-19 at 10 45 29 AM

@javierarce walked through a few ideas in this comment, but ultimately we landed on what you see now.

@ryelle
Copy link
Contributor

ryelle commented Sep 19, 2022

Maybe there could be more space between the menu items to make it clear the text + chevron are a unit?

@ryelle ryelle transferred this issue from WordPress/wporg-main-2022 Sep 19, 2022
@jasmussen
Copy link
Collaborator

We can address the left padding of the chevron button so it's closer to the title, and add a negative right-margin if need be, to compensate for the increased visual spacing between items.

@javierarce
Copy link
Collaborator

javierarce commented Sep 21, 2022

I think that if we reduced the left padding of the arrows to 4px we could achieve what we designed:

image

The focused states will look unbalanced, but I think it's OK.

PS: Something we should also tweak is the vertical position of the arrows.

@javierarce
Copy link
Collaborator

Thanks for the fix! I created a new issue for the vertical position of the chevrons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants