Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Refine and polish the dropdown menus #361

Closed
2 tasks
jasmussen opened this issue Mar 28, 2023 · 0 comments
Closed
2 tasks

Navigation: Refine and polish the dropdown menus #361

jasmussen opened this issue Mar 28, 2023 · 0 comments
Assignees

Comments

@jasmussen
Copy link
Collaborator

jasmussen commented Mar 28, 2023

From WordPress/wporg-main-2022#221

Dropdown shall have some bottom padding in the menu – when the last item is active it looks visually stressed.
The dropdown flyout is 1px off to the left.

Screenshot 2023-03-28 at 10 56 17

  • Add some bottom padding to the dropdown menu

Mockup that adds 12px extra bottom padding:

Dropdown bottom padding

Note that this will be less urgent if #360 is addressed, but would still be worth having.


Secondly, there's an issue with the dropdown positioning, it's 1px off, which is most visible on the About subpages:

Screenshot 2023-03-28 at 10 56 35

  • Fix the positioning of the dropdown menu to not be 1px off

This is likely due to the left: -1px; rule applied to the dropdown menu:

Screenshot 2023-03-28 at 11 46 16

This negative margin exists when the menu uses "default colors" (in this case external colors unknown to the navigation block), and this is set to 0 as soon as the navigation block has-background, for example. See also: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/navigation/style.scss#L272

@jasmussen jasmussen added the [Type] Enhancement New feature or request label Mar 28, 2023
@ryelle ryelle transferred this issue from WordPress/wporg-main-2022 Mar 28, 2023
@ryelle ryelle self-assigned this Mar 28, 2023
@ryelle ryelle closed this as completed in dfa73c2 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants