Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local navigation bar: Dropdown nav layout broken on mobile #592

Closed
ryelle opened this issue Mar 27, 2024 · 2 comments
Closed

Local navigation bar: Dropdown nav layout broken on mobile #592

ryelle opened this issue Mar 27, 2024 · 2 comments

Comments

@ryelle
Copy link
Contributor

ryelle commented Mar 27, 2024

Looks like this is a global issue with the local nav block CSS, because the navigation block no longer uses the is-collapsed class (see WordPress/gutenberg@ad1c0b4), none of the CSS here is applied anymore.

That class was the easiest way to target the menu when it was in the "chevron" state (whether that was because it was mobile screen size or the always-mobile version), removing it would apply that CSS to the inline menu too.

Screenshot

Production (broken) Expected
Image Image
@ryelle ryelle changed the title Fix local nav layout on mobile Local navigation bar: Dropdown nav layout broken on mobile Mar 27, 2024
@ryelle
Copy link
Contributor Author

ryelle commented Mar 27, 2024

@adamwoodnz Are you actively working on this? I saw it was high priority & in progress in the Forums board (I used that card to create this issue, it applies to all the sites — my screenshot above is from Patterns).

@ryelle ryelle self-assigned this Mar 27, 2024
@ryelle ryelle closed this as completed in 5370523 Mar 27, 2024
@adamwoodnz
Copy link
Contributor

@adamwoodnz Are you actively working on this? I saw it was high priority & in progress in the Forums board (I used that card to create this issue, it applies to all the sites — my screenshot above is from Patterns).

I was not, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants