-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Box, Flex, and Stack #771
Comments
Hi @alanbsmith I get the truncation is an example - but note that the overflow:ellipsis pattern that uses the title attribute isn't accessible to touch, dictation or keyboard users. I do think a primitive for headings would be helpful as reusable components will appear in different contexts, at different levels in the document heading structure. It should therefore be allowed to change the heading level of the component’s main heading via a level primitive / prop. The Note that It is recommended the default prop value is This would obviously be used as a workaround when heading levels are proving challenging to refactor.
|
Thanks for the feedback, @mathalete! I made this issue as a quick note, but we should talk about it more. 😀 There are a lot of situations where truncation is being used (or will potentially be used), and I’d like to have a11y guarantees and guidelines all in one spot. That’ll make it easier for everyone to get it right on the first pass. |
🚀 Feature Proposal
We should add spacing / layout components to canvas-kit. We can start with the following:
Motivation
This is an important part of developing a component hierarchy that will enable us to make canvas-kit more flexible and extensible.
Other links:
Box
Flex
Example
Here's a proof of concept for
Box
,Flex
, andStack
The text was updated successfully, but these errors were encountered: