Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize prop spread behavior naming #95

Closed
anicholls opened this issue Aug 9, 2019 · 0 comments · Fixed by #150
Closed

Standardize prop spread behavior naming #95

anicholls opened this issue Aug 9, 2019 · 0 comments · Fixed by #150
Projects
Canvas Kit API Changes

Comments

@anicholls
Copy link
Contributor

🐛 Bug Report

We have various names for elemProps and we should standardize on one (see https://github.com/Workday/canvas-kit/blob/master/API_PATTERN_GUIDELINES.md#prop-spread-behavior).

Pulled from #51, but not breaking.

Cases that need to be updated:

  • ActionBar uses props
  • TextArea and TextInput use inputProps
  • Various components use otherProps

I think this is all, but good to do another pass.
@anicholls anicholls added the bug Something isn't working label Aug 9, 2019
@anicholls anicholls added this to To do in Canvas Kit API Changes via automation Aug 9, 2019
@anicholls anicholls added p:3 and removed bug Something isn't working labels Aug 9, 2019
@anicholls anicholls mentioned this issue Aug 9, 2019
Closed
@anicholls anicholls mentioned this issue Aug 27, 2019
Merged
9 tasks
Canvas Kit API Changes automation moved this from To do to Done Sep 6, 2019
@jaclynjessup jaclynjessup removed the p:3 label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Canvas Kit API Changes
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Standardize elemProps prop spread behavior anicholls/canvas-kit
2 participants
@anicholls @jaclynjessup