Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash and merge breaks pre-approval process #43

Open
ScottBishop opened this issue Jun 25, 2019 · 0 comments
Open

Squash and merge breaks pre-approval process #43

ScottBishop opened this issue Jun 25, 2019 · 0 comments

Comments

@ScottBishop
Copy link
Contributor

When approving an image on a pull request, the git sha is stored with the image. If a developer squashes his or her commits before merging into master, that pre-approval will slip through the cracks and it will appear on the master branch.

Maybe we can use solely the PR number to pre-approve an image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant