UIP-3197 Ignore imports in strings

[nickclmb]

At the moment dependency validator thinks that this is real import:

void main() {
  final content = '''import 'package:test/test.dart';'''
  ...
}

[evanweible-wf]

Thanks for reporting this @nickclmb! We currently use a regex to quickly detect imports in files, which is why this is getting picked up. This one might be tough to fix without properly using the analyzer to build the AST... any ideas @Workiva/app-frameworks?

[aaronlademann-wf]

@evanweible-wf a "real" import would always start with the word import, so we could use the ^ character in the regex to specify that?

dependency_validator/lib/src/utils.dart

Lines 20 to 21 in e8e2e7d

	final RegExp importExportPackageRegex =
	new RegExp(r'''\b(import|export)\s+['"]{1,3}package:([a-zA-Z0-9_]+)\/[^;]+''', multiLine: true);

final RegExp importExportPackageRegex =
    new RegExp(r'''^\s*(import|export)\s+['"]{1,3}package:([a-zA-Z0-9_]+)\/[^;]+''', multiLine: true);

Something like that?

[nickclmb]

Hi @edwardcupps-wf, the ^ character will undo the feature when multiple imports written in one row.
Probably something like this will work:

final RegExp importExportPackageRegex = 
     new RegExp(r'''^(\s*(import|export)\s+['"]{1,3}package:([a-zA-Z0-9_]+)\/[^;]+['"]{1,3};)+'''); 

it wraps single import into group, so it can handle multiple imports in a row, and ignore strings like

'import "package:name/path.dart"';
// import 'package:name/path.dart';

[aaronlademann-wf]

@evanweible-wf ^

[jacehensley-wf]

I think Evan is right, the real path forward would be to use the AST

[greglittlefield-wf]

@evanweible-wf Agreed; we could make adjustments to the Regex to fix this case, but I think our time would be better spent just implementing the AST solution (which I don't foresee taking much time) vs wrestling with edge cases and the Regex.

[matthewnitschke-wk]

This issue has been resolved in #111, and will be included in the v4.0.0 release