Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n drop bugs, FireFox and IE #61

Open
grumpy opened this issue Jul 28, 2015 · 1 comment
Open

Drag n drop bugs, FireFox and IE #61

grumpy opened this issue Jul 28, 2015 · 1 comment

Comments

@grumpy
Copy link
Contributor

grumpy commented Jul 28, 2015

In FireFox there is an error in syntheticDataTransferFactory, because the arrays files and types can be null instead of zero length.
In IE there is an error when dragging items from outside the browser, because IE forbids access to effectAllowed in this case.

I have a quick PR that prevents both of these errors.

I also wanted to discussion the possibility of changing the events, by changing all of the SyntheticEvent classes to each be a simple proxy that wraps an instance if JsObject, instead of copying all of the values from the object during construction. This was mentioned in #49 as a possible performance improvement, and I think it could improve the code as well. I am curious if anyone else would see any drawbacks or problems with this idea.

@grumpy
Copy link
Contributor Author

grumpy commented Jul 28, 2015

See #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant