Add HuggingFace-compatible PreTokenizer #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh-northlander
approved these changes
Nov 19, 2021
eiennohito
force-pushed
the
38-pretokenizer
branch
from
58d8893
to
136ce95
Compare
|
Added custom handler |
eiennohito
force-pushed
the
38-pretokenizer
branch
from
b0f9961
to
2a02b25
Compare
also add custom transformations to pretokenizer
eiennohito
force-pushed
the
38-pretokenizer
branch
from
2a02b25
to
4d4f59c
Compare
|
rebased on develop branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #176 (includes its comments)
Fixes #38 Fixes #166 #Fixes #168
Created as
Dictionary.pre_tokenizer([mode]), where the default mode is C.Implementation can be used from multiple threads, with a single PreTokenizer instance shared between all threads. It will create thread local Sudachi tokenizer and use it to perform the actual tokenization. Also, implementation releases GIL while doing the analysis, so it should achieve some speedup when used multithreaded.