-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Plugin Loading #39
Merged
mh-northlander
merged 11 commits into
WorksApplications:develop
from
eiennohito:plugins
Sep 29, 2021
Merged
Refactor Plugin Loading #39
mh-northlander
merged 11 commits into
WorksApplications:develop
from
eiennohito:plugins
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Refactor common logic (fixes WorksApplications#24) 2) Resolve in-path variables (fixes WorksApplications#21)
Need to finish moving plugins into the main package to fix failing tests. |
This PR also should be squashed, I think. |
@mh-northlander ready for review & merging |
Closed
mh-northlander
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17 Fixes #19 Fixes #20 Fixes #21 Fixes #24
$exe/plugin
or relative to the configuration folder$cfg/plugin
.plugin
instead oflibplugin.so
. First name will correctly resolve on Windows/Linux/macOS.Main design for the rework of plugin loader
We have core logic of plugin loading in a
PluginLoader
struct which is generic over implementations ofPluginCategory
trait.PluginCategory
captures plugin category specific logic: providing specific types, configuration extraction, and instantiation of bundled plugins.PluginLoader is using fully qualified trait call syntax (see previous paragraph before this link). It is required because type inference does not work if T is not present as one of arguments.