Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease size of Node #71

Closed
eiennohito opened this issue Oct 8, 2021 · 0 comments · Fixed by #94
Closed

Decrease size of Node #71

eiennohito opened this issue Oct 8, 2021 · 0 comments · Fixed by #94
Labels
performance Something is slow

Comments

@eiennohito
Copy link
Collaborator

eiennohito commented Oct 8, 2021 •
edited

Nodes are copied around a lot and Rust does not have placement semantic yet.
The easiest way to improve the analysis speed is to decrease the size of the Node structure.

It should be made at most 32 bytes (currently 264 bytes).
It means that most of the fields must go away and WordInfo must be moved out of the structure.
@eiennohito eiennohito added the performance Something is slow label Oct 8, 2021
This was referenced Oct 11, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Something is slow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Node into smaller things eiennohito/sudachi.rs
1 participant
@eiennohito