Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely manage not awaited calls #22

Closed
1 task
WorldWideWest opened this issue Feb 24, 2024 · 0 comments · Fixed by #23
Closed
1 task

Safely manage not awaited calls #22

WorldWideWest opened this issue Feb 24, 2024 · 0 comments · Fixed by #23

Comments

@WorldWideWest
Copy link
Owner

Description

Multiple calls on methods implemented in email service weren't handled properly. Make sure to handle them, follow this article for more info on that How to safely call an async method in C# without await and use the logger to log the exception

These are the places where I found unhandled calls:

  1. src/Template.Application/Identity/Commands/ResendConfirmationEmail/ResendConfirmationEmailCommandHandler.cs
  2. src/Template.Application/Identity/Commands/ForgotPassword/ForgotPasswordCommandHandler.cs
  3. src/Template.Application/Identity/Commands/CreateUser/CreateUserCommandHandler.cs

Acceptance Criteria

  • All three places are adjusted and log the exception into the terminal
@WorldWideWest WorldWideWest linked a pull request Feb 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant