Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strain duplicates #220

Closed
draciti opened this issue Aug 24, 2021 · 10 comments
Closed

Strain duplicates #220

draciti opened this issue Aug 24, 2021 · 10 comments
Assignees
Milestone

Comments

@draciti
Copy link
Collaborator

draciti commented Aug 24, 2021

One strain was extracted (OH12312) for this paper
Tried to add the same strain and see them as duplicates -see screenshot.
Screen Shot 2021-08-24 at 9 05 02 AM

Also, should we add WBstrain IDs next to the strains that were extracted?

@draciti draciti added this to the v3.0 milestone Aug 24, 2021
@valearna
Copy link
Collaborator

Show a message in a popup window when the user adds an entity for which there is an entry with name only already in the box.

valearna added a commit that referenced this issue Aug 31, 2021
@valearna
Copy link
Collaborator

Added the error message in a popup only for strains - i.e., the popup is not shown for genes and other datatypes

@valearna
Copy link
Collaborator

valearna commented Sep 3, 2021

Modify the form to always get the entity added, including the WBStrainID

@valearna
Copy link
Collaborator

valearna commented Sep 7, 2021

Can you test the 'add entity' component again @draciti @vanaukenk and let me know if everything looks good?

@vanaukenk
Copy link
Collaborator

@valearna
It looks fine to me. Thx.
@draciti - do you also want to double-check?

@draciti
Copy link
Collaborator Author

draciti commented Sep 7, 2021 via email

@vanaukenk
Copy link
Collaborator

One other thought. If the Strain autocomplete is empty, but the user clicks on 'Add selected', they still get the message that strains in the final list have been replaced.
If the autocomplete field is empty, we should always present the pop-up message about No entities selected.

@valearna
Copy link
Collaborator

valearna commented Sep 7, 2021

Thanks @vanaukenk, I'll fix the pop-up messages

@valearna
Copy link
Collaborator

valearna commented Sep 7, 2021

@vanaukenk I fixed the pop-up issue

@draciti
Copy link
Collaborator Author

draciti commented Sep 8, 2021

All good, tested both adding new and existing strains, and pop-up functionality. Closing

@draciti draciti closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants