-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strain duplicates #220
Comments
Show a message in a popup window when the user adds an entity for which there is an entry with name only already in the box. |
Added the error message in a popup only for strains - i.e., the popup is not shown for genes and other datatypes |
Modify the form to always get the entity added, including the WBStrainID |
Can you test the 'add entity' component again @draciti @vanaukenk and let me know if everything looks good? |
Will do!
…________________________________
From: vanaukenk ***@***.***>
Sent: Tuesday, September 7, 2021 1:53 PM
To: WormBase/author-first-pass ***@***.***>
Cc: Raciti, Daniela ***@***.***>; Mention ***@***.***>
Subject: Re: [WormBase/author-first-pass] Strain duplicates (#220)
@valearna<https://github.com/valearna>
It looks fine to me. Thx.
@draciti<https://github.com/draciti> - do you also want to double-check?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#220 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAG4A64H4N33I36TJH2KY2DUAZ3UDANCNFSM5CW5P5IA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
One other thought. If the Strain autocomplete is empty, but the user clicks on 'Add selected', they still get the message that strains in the final list have been replaced. |
Thanks @vanaukenk, I'll fix the pop-up messages |
@vanaukenk I fixed the pop-up issue |
All good, tested both adding new and existing strains, and pop-up functionality. Closing |
One strain was extracted (OH12312) for this paper
![Screen Shot 2021-08-24 at 9 05 02 AM](https://user-images.githubusercontent.com/901243/130631363-49ffa517-5e4f-45c6-9af0-8cf17fe8fafb.png)
Tried to add the same strain and see them as duplicates -see screenshot.
Also, should we add WBstrain IDs next to the strains that were extracted?
The text was updated successfully, but these errors were encountered: