Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimulationCraft Bloodlust/Heroism/Time Warp/Fury of the Aspects per pull does not update with new pulls #1941

Closed
Wotuu opened this issue Aug 11, 2023 · 0 comments
Closed

SimulationCraft Bloodlust/Heroism/Time Warp/Fury of the Aspects per pull does not update with new pulls #1941

Wotuu opened this issue Aug 11, 2023 · 0 comments
Assignees
@Wotuu
Labels
bug Something isn't working

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Aug 11, 2023

The dropdown is populated on page load but doesn't update if you edit pulls and then open the window again. It should populate on modal load, not on page load.
@Wotuu Wotuu added the bug Something isn't working label Aug 11, 2023
Wotuu added a commit that referenced this issue Aug 11, 2023
@Wotuu
#1941 SimulationCraft pulls are now updated upon modal opening and no…
323e793 
…t on load.

This allows the modal to have up-to-date info about pulls if you've edited them in your current session
@Wotuu Wotuu closed this as completed Aug 22, 2023
@Wotuu Wotuu self-assigned this Aug 22, 2023
This was referenced Aug 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wotuu