Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infested affix support #39

Closed
Wotuu opened this issue Oct 9, 2018 · 1 comment
Closed

Infested affix support #39

Wotuu opened this issue Oct 9, 2018 · 1 comment
Assignees
@Wotuu
Labels
enhancement New feature or request high priority High priority issues that should be picked up quickly question Further information is requested

Comments

@Wotuu
Copy link
Collaborator

Wotuu commented Oct 9, 2018 •
edited

I wanted to include this for launch, until I saw that the Infested mobs change every week and thus cannot be mapped traditionally.

I was thinking about adding a voting system where people can vote a mob yes/no as being Infested this week. Min amount of votes something like 2-3, if there's that amount of votes the mob is marked as Infested. No votes to allow incorrectly marked mobs as Infested as non-infested again if the amount of No votes is higher than the amount of Yes votes.

Any other ideas perhaps? This is something I want to work on sooner rather than later.
@Wotuu Wotuu added enhancement New feature or request question Further information is requested labels Oct 9, 2018
@ghost
Copy link

ghost commented Oct 9, 2018

Should be a good solution. Another option, which is more accurate but also requires more work to get it to work, is to write a small addon that scans mobs inside a dungeon to look for that Spell ID. Definitely would go for your suggestion first.

@Wotuu Wotuu added the high priority High priority issues that should be picked up quickly label Oct 10, 2018
@Wotuu Wotuu self-assigned this Oct 16, 2018
Wotuu added a commit that referenced this issue Oct 19, 2018
@Wotuu
#39 WIP infested affix support.
301ba07
@Wotuu Wotuu mentioned this issue Oct 19, 2018
Closed
Wotuu added a commit that referenced this issue Oct 21, 2018
@Wotuu
#39 #62 Started work on Infested votes. The back-end for that is most…
b0daa52 
…ly done, but the front-end needs work still. For that, I rewrote the entire visuals for all enemies to contain of 4 elements. One main visual, and three modifiers (such as raid markers, Infested and see-through-stealth). The modifiers are fixed in position, the main visual can be changed by the user on demand by using a new dropdown on the map.

This should close #62, as the rewriting/adding of display layers is now done, or done enough. This system can now be extended and be used, will no longer require rewrites or anything major. More work being done it it should be minor fixes.
Wotuu added a commit that referenced this issue Oct 23, 2018
@Wotuu
#39 Added infested supported for modifiers with accompanying adjustme…
92cb6b1 
…nts to the EnemyVisual system. Added a new 'infested voting' (name subject to change) layer which allows a user to vote all existing mobs for Infesting or not (not functional atm).

Use interface is almost done, perhaps some touch ups still, but other than that I can work on tying the front end and the back-end together. I'll still need a way to visualize how many votes are required for turning an enemy into an Infested enemy. And also work on the back end a bit so that Infested votes of a previous week are disregarded (not discarded yet!) AND need to add a Region toggle so that people in the EU will get served Infested enemies a day longer than their US counterparts.
Wotuu added a commit that referenced this issue Oct 24, 2018
@Wotuu
#39 Infested support is mostly implemented now. You can now vote for …
9c85d6a 
…all enemies if they're Infested or not. The front-end is now coupled with the back-end and everything is functioning as intended.

TODO: add localization selection for each profile (EU/US/Oceanic/more?) so resets are handled differently for each of those players. There's a bug where switching floors causes the visualization dropdown to clear of entries.
Wotuu added a commit that referenced this issue Oct 25, 2018
@Wotuu
#39 Started work on restricting votes based on user's region and time…
2327151 
…zones.
Wotuu added a commit that referenced this issue Oct 25, 2018
@Wotuu
#39 Infested votes now account for affix group and a creation time. A…
7e566d1 
…dded ID display to enemies for admins.
Wotuu added a commit that referenced this issue Oct 26, 2018
@Wotuu
#39 Fixed Infested votes not saving correctly due to lacking affix_gr…
75a1666 
…oup_id. Started on fixing a bug in the admin with enemies saving clearing their visual type but ran out of time.
Wotuu added a commit that referenced this issue Oct 26, 2018
@Wotuu
Re-imported all enemies. Mostly changes due to #39 requiring some mor…
ed94fa5 
…e space between some enemies so the buttons don't overlap for voting for Infested.
@Wotuu Wotuu mentioned this issue Oct 26, 2018
Merged
@Wotuu Wotuu closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
enhancement New feature or request high priority High priority issues that should be picked up quickly question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wotuu