New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The percentage displayed on attempts seems to be off for items that are tracked repeatedly #671

Open

Duckwhale opened this issue Oct 19, 2023 · 0 comments

Labels

Complexity: Low Priority: Normal Scope: GUI Status: Accepted Type: Bug

Projects

Member

Duckwhale commented Oct 19, 2023

Source: Discord

When farming a mount the text is showing something like "100 attempts - 10%"
If I wanna farm it multiple times it is now showing "100 attempts (200 total) - 20%"
Is there any way to keep the total but the percentage only tracking the current attempts ?

Hmm, I think it's an oversight? The code seems to account for last attempts by subtracting them, but it looks like the percentage is computed before that
Pinging Rubio since they submitted the PR. The lines I'm referring to are these (chance is calculated first, then item.lastAttempts is subtracted):

Just putting this here since I randomly saw it on Discord while searching for something unrelated, before I forget.

Duckwhale added Priority: Normal Status: Accepted Type: Bug Complexity: Low Scope: GUI labels

Duckwhale added this to Soon™ in Timeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment