Fix a few linter warnings

src/game_settings.rs

@@ -226,6 +226,7 @@ fn use_my_games_directory(ini_path: &Path) -> bool {
 mod tests {
     extern crate tempdir;
 
+    #[cfg(windows)]
     use std::env;
     use std::io::Write;
     use self::tempdir::TempDir;

src/ghostable_path.rs

@@ -251,6 +251,6 @@ mod tests {
 
     #[test]
     fn resolve_path_should_error_if_no_path_exists() {
-        let mut path = Path::new("foo").resolve_path().is_err();
+        assert!(Path::new("foo").resolve_path().is_err());
     }
 }

src/load_order/error.rs

@@ -58,7 +58,7 @@ impl From<Cow<'static, str>> for LoadOrderError {
 }
 
 impl From<regex::Error> for LoadOrderError {
-    fn from(error: regex::Error) -> Self {
+    fn from(_: regex::Error) -> Self {
         LoadOrderError::InvalidRegex
     }
 }

src/load_order/methods/textfile.rs

@@ -22,13 +22,11 @@ use encoding::{DecoderTrap, Encoding, EncoderTrap};
 use encoding::all::WINDOWS_1252;
 use unicase::eq;
 
-use game_settings::GameSettings;
 use plugin::Plugin;
 use load_order::{create_parent_dirs, find_first_non_master_position, read_plugin_names};
 use load_order::error::LoadOrderError;
 use load_order::mutable::MutableLoadOrder;
 use load_order::readable::ReadableLoadOrder;
-use load_order::writable::WritableLoadOrder;
 
 pub fn insert_position<T: ReadableLoadOrder>(load_order: &T, plugin: &Plugin) -> Option<usize> {
     let is_game_master = plugin

src/load_order/methods/timestamp.rs

@@ -33,7 +33,6 @@ use load_order::{create_parent_dirs, find_first_non_master_position};
 use load_order::error::LoadOrderError;
 use load_order::mutable::MutableLoadOrder;
 use load_order::readable::ReadableLoadOrder;
-use load_order::writable::WritableLoadOrder;
 
 pub fn insert_position<T: ReadableLoadOrder>(load_order: &T, plugin: &Plugin) -> Option<usize> {
     if plugin.is_master_file() {

src/load_order/writable.rs

@@ -146,7 +146,7 @@ mod tests {
     }
 
     impl MutableLoadOrder for TestLoadOrder {
-        fn insert_position(&self, plugin: &Plugin) -> Option<usize> {
+        fn insert_position(&self, _: &Plugin) -> Option<usize> {
             None
         }
 
@@ -167,16 +167,12 @@ mod tests {
         }
 
         // Dummy method, unused.
-        fn set_load_order(&mut self, plugin_names: &[&str]) -> Result<(), LoadOrderError> {
+        fn set_load_order(&mut self, _: &[&str]) -> Result<(), LoadOrderError> {
             Ok(())
         }
 
         // Dummy method, unused.
-        fn set_plugin_index(
-            &mut self,
-            plugin_name: &str,
-            position: usize,
-        ) -> Result<(), LoadOrderError> {
+        fn set_plugin_index(&mut self, _: &str, _: usize) -> Result<(), LoadOrderError> {
             Ok(())
         }
     }