Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to compare full directories instead of only files #11

Closed
aneveux opened this issue Feb 26, 2018 · 3 comments
Closed

Allow to compare full directories instead of only files #11

aneveux opened this issue Feb 26, 2018 · 3 comments
Assignees

Comments

@aneveux
Copy link
Member

aneveux commented Feb 26, 2018

When computing approval tests, the framework should allow not only to compare single files, but to compare full directories containing several files/folders.

Given a batch method, generating directories and files,
When running the approval tests,
Then the framework should compare all the generated data (files and folders hierarchy) with a reference one, committed along with the source code.

@aneveux aneveux added this to To do in approvals-java via automation Feb 26, 2018
@tyrcho tyrcho moved this from To do to In progress in approvals-java Feb 26, 2018
@tyrcho
Copy link
Member

tyrcho commented Mar 2, 2018

compare folder.received with folder.approved instead of comparing in the resources each file.approved with file.received => DONE in e0db552

@tyrcho tyrcho closed this as completed in e4804aa Mar 15, 2018
approvals-java automation moved this from In progress to Done Mar 15, 2018
@tyrcho
Copy link
Member

tyrcho commented Mar 15, 2018

demo code in this class

@tyrcho
Copy link
Member

tyrcho commented Mar 15, 2018

@aneveux @jmdesprez Would you please test this feature from your side also ? Then we can release it in 0.4 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants