Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious Obelisk message doesn't count as dialogue #1951

Open
Mcrtin opened this issue Aug 7, 2023 · 13 comments · Fixed by #2139
Open

Mysterious Obelisk message doesn't count as dialogue #1951

Mcrtin opened this issue Aug 7, 2023 · 13 comments · Fixed by #2139
Labels
bug Something isn't working confimed

Comments

@Mcrtin
Copy link
Contributor

Mcrtin commented Aug 7, 2023

image

@magicus
Copy link
Member

magicus commented Aug 7, 2023

Well, should it..? We do not and cannot capture all Wynn messages that are printed to the chat. There is in principle no way for us to know that this is part of the quest.

Unless you see the message on a new "chat page" on vanilla, this is intended behavior.

@magicus magicus closed this as completed Aug 7, 2023
@Mcrtin
Copy link
Contributor Author

Mcrtin commented Aug 7, 2023

it resends the messages from before as you can see in the screenshot after the "as you touch..." message. Idk what you would call that but I don't like the resend messages and maybe we can redirect the "as you..." to Notafications.

@magicus magicus reopened this Aug 8, 2023
@magicus
Copy link
Member

magicus commented Aug 8, 2023

Ok, we'll have to investigate. Are there any requirements for interacting with this obelisk? (I've missed it, is it part of the time valley mini bosses thing?)

@Mcrtin
Copy link
Contributor Author

Mcrtin commented Aug 8, 2023

idk i just click on it with my main (100% quests before 2.0)

@Mcrtin
Copy link
Contributor Author

Mcrtin commented Aug 8, 2023

"A mysterious crystal found in Nemract and Tempo Town. It requires the completion of Tempo Town Trouble."https://wynncraft.fandom.com/wiki/Fast_Travel#Mysterious_Obelisk

@Mcrtin Mcrtin changed the title Mysterious Obelisk message doesn't count as quest dialogue Mysterious Obelisk message doesn't count as dialogue Aug 8, 2023
@MenacingPerson
Copy link

This was added in 2.0.3

@kristofbolyai
Copy link
Collaborator

Yes, but supporting is edge case is rather hard, for no benefit..

@magicus
Copy link
Member

magicus commented Sep 26, 2023

I am a bit skeptical if this can/should be fixed, but I'll go and have a look at the obelisk dialogue myself first before closing this.

@Mcrtin
Copy link
Contributor Author

Mcrtin commented Sep 26, 2023

This can only be matched by hard coding the string

@magicus
Copy link
Member

magicus commented Sep 26, 2023

If that is the only solution, then we will not fix it. However, you stated before:

it resends the messages from before as you can see in the screenshot after the "as you touch..." message.

and that matches a general pattern how Wynn treats NPC messages. This is behavior that we can match on (and, in general, we ought to already do).

@Mcrtin
Copy link
Contributor Author

Mcrtin commented Sep 28, 2023

The messages are resent but only after a few seconds so during that time we have no idea that the message is dialogue if we don't match the exact string and therefore it can't be displayed as one.

@magicus
Copy link
Member

magicus commented Sep 29, 2023

I checked this out myself now. The bug report is correct, but your speculation to the cause is way off.

Wynncraft sends "chat screens" as for NPC dialogues here, but for some reason, we fail to detect when the chat screen is done. It has nothing to do with the actual message being sent.

@magicus magicus added bug Something isn't working confimed labels Sep 29, 2023
@Mcrtin
Copy link
Contributor Author

Mcrtin commented Sep 29, 2023

Thx for the confirmation.
I didn't know that we have a way of detecting something like that, but I'm glad we do. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confimed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants