Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing two pieces of gear will sometimes make the tooltips overlap #2179

Open
EpicPuppy613 opened this issue Oct 9, 2023 · 4 comments
Open

Comments

@EpicPuppy613
Copy link

image
Its very inconsistent where its perfectly fine with some comparisons, but others (like the one shown above) overlap and is sometimes hard to read.

@Rafii2198
Copy link
Contributor

This might be unrelated and could be caused by legendary tooltips (I will do proper checks at a later time) but it seems like if the second tooltip doesn't have enough horizontal space it tries to be rendered on the other side, but it goes to weird x positions.
2023-10-09_02 09 59
On this example, you can see that I am comparing a chestplate in my inventory with my boots, the tooltip of the boots is going to the left of them and thus the chestplate tooltip is trying to render on the left of that tooltip, but it would not fit the screen and tries to render on the right but fails to determine right x position.

@EpicPuppy613
Copy link
Author

This might be unrelated and could be caused by legendary tooltips (I will do proper checks at a later time) but it seems like if the second tooltip doesn't have enough horizontal space it tries to be rendered on the other side, but it goes to weird x positions.

Another theory for this might be because the tooltip is too big, so when it renders, it scales the entire screen up, but it doesn't account for the scaled up screen when offsetting the x position

@EpicPuppy613
Copy link
Author

EpicPuppy613 commented Oct 12, 2023

I have spotted the main issue, the x offset is not accounting for the fact that the item name could be bold (perfect) or the percentage numbers on the identification. I might give a go at fixing this.
image

@EpicPuppy613
Copy link
Author

I tried fixing it, but the tooltip system is just really goofy and stupid. I'll try to commit a partial fix soon, but this issue is definitely going to take a bit to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants