feat: Add RevealNicknamesFeature #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kristofbolyai
commented
Apr 16, 2024
•
kristofbolyai
commented
ShadowCat117
approved these changes
Apr 16, 2024
|
I am not merging this until I figure out a |
|
Didn't even notice that, I don't think I experienced it when trying out the feature either |
Yeah, but I get it, and I dumped all sibling-style pairs and I can see that the produced style is different. However, I couldn't get further because of time constraints. |
|
Fixed version: 
|
…t part's style even if it is not supposed to
kristofbolyai
commented
Apr 17, 2024
Comment on lines
+533
to
+538
| // The reconstructed componenet differs in that StyledText always adds components as a sibling to an empty | ||
| // component | ||
| Assertions.assertEquals( | ||
| component, styledText.getComponent(), "StyledText.getComponent() returned an unexpected value."); | ||
| component.toFlatList(), | ||
| styledText.getComponent().toFlatList(), | ||
| "StyledText.getComponent() returned an unexpected value."); |
There was a problem hiding this comment.
This is not fully ideal, but at least we produce a more correct component (at least, it behaves like the original one, even if the structures differ).
kristofbolyai
commented
Apr 17, 2024
| @@ -836,7 +840,7 @@ public void styledText_inheritesHoverEvents() { | |||
|
|
|||
| Assertions.assertEquals( | |||
| component.getStyle().getHoverEvent(), | |||
| styledText.getComponent().getStyle().getHoverEvent(), | |||
| styledText.getComponent().toFlatList().get(0).getStyle().getHoverEvent(), | |||
There was a problem hiding this comment.
This test was wrong.
magicus
approved these changes
Apr 17, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 18, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 18, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 21, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 22, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 24, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 25, 2024
kristofbolyai
added a commit
that referenced
this pull request
Apr 28, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 5, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.