feat: Add soulpoint subcommand and aliases for server commands, click-to-switch server texts, fix formatting issues, command no longer hands the game #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-switch server texts, fix formatting issues, command no longer hands the game The timeouts were removed since the ServerListModel now automatically updates every 15 seconds, no need for the manual force updates now, and the running the command feels much faster now.
kristofbolyai
changed the title
ShadowCat117
approved these changes
Apr 20, 2024
/servers is a Wynn command. So that, I guess. |
Ahh that would do it |
Fixed it anyways |
kristofbolyai
added a commit
that referenced
this pull request
Apr 21, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 21, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
|
The updating every 15 seconds, were that done before? I can't figure it out from this PR. (Also, are we caching results in Athena or polling Wynncraft every 15 second?) |
I recently introduced it, when I added a server uptime overlay. We use athena (for the better or for the worse, Athena performance is really bad recently..) |
kristofbolyai
added a commit
that referenced
this pull request
Apr 22, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 23, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 24, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 25, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
Apr 28, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
May 5, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
kristofbolyai
added a commit
that referenced
this pull request
May 13, 2024
…-to-switch server texts, fix formatting issues, command no longer hands the game (#2415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeouts were removed since the ServerListModel now automatically updates every 15 seconds, no need for the manual force updates now, and the running the command feels much faster now.