Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ProfessionHighlightFeature #2424

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

kristofbolyai
Copy link
Collaborator

Although this feature is not in fuy.gg, but Wynntils Legacy/avomod2, I just added it due to a request. I've improved the original version with a per-container config option.

image

Although this feature is not in fuy.gg, but Wynntils Legacy/avomod2, I just added it due to a request.
@ShadowCat117
Copy link
Contributor

I would also suggest to either make PersonalStorageContainer implement HighlightableProfessionProperty or make account/character bank and misc bucket implement it

Copy link
Contributor

@ShadowCat117 ShadowCat117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now. I may look into the other changes I suggested after doing the raid stuff for the fuy features but this is good for now :)

@kristofbolyai kristofbolyai merged commit 24335bd into fuygg_features Apr 24, 2024
1 check passed
@kristofbolyai kristofbolyai deleted the ingredient-selector branch April 24, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants