feat: Add guild bank redirector in ChatRedirectFeature #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kristofbolyai
commented
Apr 25, 2024
kristofbolyai
commented
ShadowCat117
approved these changes
Apr 25, 2024
|
Ended up changing the color for community opinion: |
|
As a side note, the Chat redirector has really outgrown itself as a feature. I think we should have a model (*) for this, were we can register the parsers. It is encoding a lot of "knowledge" about Wynncraft messages and what they mean. (*) or maybe another Component; I'm not sure... |
|
Probably the extension of existing chat types in some ways. |
kristofbolyai
added a commit
that referenced
this pull request
Apr 28, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 1, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 1, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 5, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.