feat: Add ExtendedSeasonLeaderboardFeature #2431
Conversation
|
I think you need to change labelInfos to a map with the season as the key and the labelinfo as the value. Changing to season 16 immediately shows the issue
|
|
The code (incl the LabelHandler changes) look fine overall, but I guess you must address Jamie's complaints first. :) |
|
Issue is still present :( Might be related but you don't seem to be adding anything to
|
|
Oh... It looked like it's working, but I guess I didn't do the math.. |
| try { | ||
| JsonElement jsonElem = Managers.Json.GSON.toJsonTree(storage.get(), storageTypes.get(storage)); | ||
| storageJson.add(jsonName, jsonElem); | ||
| } catch (Throwable t) { | ||
| WynntilsMod.error("Failed to save storage " + jsonName, t); | ||
| } |
There was a problem hiding this comment.
Only used this for debugging, but I think it should be kept, to reduce the risk of "resetting" storage files.
There was a problem hiding this comment.
Yes, I have seen some people reporting their storage file getting reset so hopefully this will help prevent that
|
@JamieCallan117 Should be fixed now |
Wynncraft Default (original)
Default with Wynntils
Short scores - optional config