Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parse shaman mask correctly when only one mask available [skip ci] #2467

Merged
merged 1 commit into from
May 7, 2024

Conversation

ShadowCat117
Copy link
Contributor

Was removed in #2402, thought that subtitle pattern had been removed but it only occurs when you have one mask ability

@ShadowCat117 ShadowCat117 changed the title fix: Parse shaman mask correctly when only one mask available [skip ci] fix: Parse shaman mask correctly when only one mask available May 7, 2024
@kristofbolyai kristofbolyai changed the title fix: Parse shaman mask correctly when only one mask available fix: Parse shaman mask correctly when only one mask available [skip ci] May 7, 2024
@kristofbolyai
Copy link
Collaborator

@JamieCallan117 I added skip-ci, but I'll do a release today, even if I don't get to push my fix.

Copy link
Collaborator

@kristofbolyai kristofbolyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is kind of like the tutorial mode for spell casting, I assume? When you are lower leveled, you have less masks, so the title is different. I see.

@kristofbolyai kristofbolyai merged commit 5141419 into Wynntils:main May 7, 2024
1 check passed
@ShadowCat117
Copy link
Contributor Author

Sort of, but even when fully levelled if you only unlock one mask in the tree it still shows the "Mask of the X" subtitle instead of the arrowed one that shows when you have 2 or 3.

@ShadowCat117 ShadowCat117 deleted the fix-shaman branch May 7, 2024 13:31
kristofbolyai pushed a commit that referenced this pull request May 13, 2024
…i] (#2467)

fix: Parse shaman mask correctly when only one mask available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants