Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI updates to Territory Management Screen + significantly faster selection when there are multiple pages #2473

Merged
merged 5 commits into from
May 15, 2024

Conversation

kristofbolyai
Copy link
Collaborator

@kristofbolyai kristofbolyai commented May 9, 2024

@kristofbolyai kristofbolyai marked this pull request as ready for review May 15, 2024 09:44
@kristofbolyai kristofbolyai changed the title feat: UI updates to Territory Management Screen feat: UI updates to Territory Management Screen + significantly faster selection when there are multiple pages May 15, 2024
@ShadowCat117
Copy link
Contributor

I think tributes are messing with the overall cost.

This is what Wynn shows on the diamond
image

And with the UI I'm seeing
image

You can probably read the tributes from the vanilla output and get changes from chat messages, unless there's a better way to do it

@kristofbolyai
Copy link
Collaborator Author

I think tributes are messing with the overall cost.

This is what Wynn shows on the diamond image

And with the UI I'm seeing image

You can probably read the tributes from the vanilla output and get changes from chat messages, unless there's a better way to do it

Yes, yes. I know that, but I didn't want to deal with having to query tributes, etc. We can fix that in an upcoming patch.

Copy link
Contributor

@ShadowCat117 ShadowCat117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the tributes, but that can be done later as you said

@kristofbolyai kristofbolyai merged commit c5a0778 into main May 15, 2024
1 check passed
@kristofbolyai kristofbolyai deleted the terr-ui-rev-2 branch May 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants