fix: Don't overwrite current world name when entering housing [skip ci] #2477
Conversation
There was a problem hiding this comment.
I believe this is the only place to have a special case to prevent the contribution message from appearing each time you entered housing but there may be other places I'm unaware of
| if (m.find()) { | ||
| String worldName = m.group(1); | ||
| String worldName = housing ? currentWorldName : m.group(1); |
There was a problem hiding this comment.
This assumes that even when joining other worlds by joining houses, you get to see the updated world name for a small bit. I only assume this is correct because of the duplicate messages this PR aims to fix, which I assume is triggered by first, the world change, then by the the world changing to "housing".
There was a problem hiding this comment.
No, this doesn't fix the changing worlds housing issue, only it changing the world name to the name of the housing, which then makes features that use current world name not work correctly. Server uptime overlay, bomb bell command/overlay, discord rich presence etc.
So since setState checks the world names aren't equal before posting the world change event, it won't incorrectly post the event as the newWorldName is still set to currentWorldName
There was a problem hiding this comment.
Okay, so it's not a full fix, but at least it patches the issue. Sure.
Should fix the minor issue from #2388 but doesn't fix the main issue.