Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't return null in profession last harvest functions [skip ci] #2479

Merged
merged 1 commit into from
May 11, 2024
Merged

fix: Don't return null in profession last harvest functions [skip ci] #2479

merged 1 commit into from
May 11, 2024

Conversation

ShadowCat117
Copy link
Contributor

Returning null makes the functions unusable until you harvest something, you can't even check for the "??" returned
image

@kristofbolyai kristofbolyai merged commit 4a46ba9 into Wynntils:main May 11, 2024
1 check passed
@ShadowCat117 ShadowCat117 deleted the null-prof-functions branch May 11, 2024 10:37
@magicus
Copy link
Member

magicus commented May 13, 2024

I think our Functions should never return null. Do we have any other instances of that, or was these the only ones?

@ShadowCat117
Copy link
Contributor Author

I think our Functions should never return null. Do we have any other instances of that, or was these the only ones?

I believe these were the only ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofbolyai kristofbolyai kristofbolyai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShadowCat117 @magicus @kristofbolyai