Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show item type for chat items, show perfect/defective #2485

Merged
merged 2 commits into from
May 12, 2024

Conversation

kristofbolyai
Copy link
Collaborator

@kristofbolyai kristofbolyai commented May 12, 2024

image
image

Copy link
Contributor

@ShadowCat117 ShadowCat117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kristofbolyai kristofbolyai merged commit b8e4a6d into main May 12, 2024
1 check passed
@kristofbolyai kristofbolyai deleted the chat-items-changes branch May 12, 2024 15:26
@magicus
Copy link
Member

magicus commented May 13, 2024

I wonder about the use of makeObfuscated here. The idea is that it should be used when we have control over the rendering, since each letter has a chance of getting replaced with a weird one. This works okay if they just flicker in and out of existence, but when sent to chat it gets permanent, so if you are unlucky one of the letters disappear and will never re-appear.

Instead I think you should just make defective items bold and dark red.

The rainbow variant is okay. While it will not move, the idea comes across and it will always be visible.

@kristofbolyai
Copy link
Collaborator Author

I wonder about the use of makeObfuscated here. The idea is that it should be used when we have control over the rendering, since each letter has a chance of getting replaced with a weird one. This works okay if they just flicker in and out of existence, but when sent to chat it gets permanent, so if you are unlucky one of the letters disappear and will never re-appear.

Instead I think you should just make defective items bold and dark red.

The rainbow variant is okay. While it will not move, the idea comes across and it will always be visible.

The chance of obfuscation is 0 here, I just used the bold/red part of the formatting.

@magicus
Copy link
Member

magicus commented May 13, 2024

Ah, I see. Then it is all good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants