Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

react-loop package breaking changes #30

Closed
ryan-eurecab opened this issue Apr 18, 2018 · 3 comments
Closed

react-loop package breaking changes #30

ryan-eurecab opened this issue Apr 18, 2018 · 3 comments

Comments

@ryan-eurecab
Copy link

Hello,

I updated my composer dependencies, since then, I get the error:
Call to undefined method React\EventLoop\StreamSelectLoop::tick() (in HttpClientAdapter.php line 149)

Indeed the method was missing from the class in the package reactphp/event-loop because another dependency updated the package to the last major update (which have some BC) where the method tick() was removed.

@WyriHaximus
Copy link
Owner

Hey @rydjeb correct we removed the tick method from the event loops. Because it didn't make sense and it supported only rare edge cases like this one. I have some PoC locally to work around it locally I have to test more before releasing it, but a fix is coming.

@WyriHaximus
Copy link
Owner

Release in 2.0.2

@ryan-eurecab
Copy link
Author

Thanks for the fix and the explanation :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants