Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280: Updater rename feature doesn't cover if scene has no "layers" pre alpha.6 #533

Open
tngreene opened this issue Feb 10, 2020 · 0 comments
Assignees
Labels
Bug priority low Updater Problems The updater is full of problems, yet is also massively important to get right. Better fix it, quick!

Comments

@tngreene
Copy link
Contributor

This whole feature was developed under the impression that "layers" would exist and we'd make decisions based on if it was an array of 20 things or not. Forgot about the case where "layers" itself might not exist, therefore not get renamed or have its visibility or have is_exportable_collection.

This is unfortunate, and the only reason I care is that something named "Collection 1.001" could be victem of this bug or it could also be an indication something went wrong with the update before the renaming could be complete. We won't know. Fortunately I think files without "layers" at all are probably rare. I hope.

The fix is probably simple:

xplane_updater.py, copy or reuse lines 78-80 if "layers" is empty or non-existant. I just can't justify the time to add to the unit test on this. We'll see what files from the wild show.

@tngreene tngreene added Bug priority low Updater Problems The updater is full of problems, yet is also massively important to get right. Better fix it, quick! labels Feb 10, 2020
@tngreene tngreene self-assigned this Feb 10, 2020
@tngreene tngreene changed the title Updater rename feature doesn't cover if scene has no "layers" pre alpha.6 280: Updater rename feature doesn't cover if scene has no "layers" pre alpha.6 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug priority low Updater Problems The updater is full of problems, yet is also massively important to get right. Better fix it, quick!
Projects
None yet
Development

No branches or pull requests

1 participant