Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GROUP and layer number system #3

Open
2 of 4 tasks
tngreene opened this issue Jul 27, 2020 · 1 comment
Open
2 of 4 tasks

Implement GROUP and layer number system #3

tngreene opened this issue Jul 27, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request priority_high Important, but it can wait

Comments

@tngreene
Copy link
Contributor

tngreene commented Jul 27, 2020

If using _PARAMs, we're using the GROUP system. If not, each sub collection just gives a layer number.

In either case the representation is the same - the 2nd level collections are the the form of "

  • Unit for good cases
    • GROUP and layer numbers given properly
    • layer number comes from name
    • collection with just "1" or whatever for a name still work
    • empty sub collection is ignored
    • All trees under the same collection share the same layer number, even if linking was used
  • Unit test for bad cases
    • bad names "1badname", "no number", "1.234 float used instead", "-1 negative number given", etc
    • duplicate layer numbers made - no collections "2 layer numbers" and "2 another collection"
  • Code for GROUP system
  • Code for regular layer system
@tngreene tngreene self-assigned this Jul 27, 2020
@tngreene tngreene added enhancement New feature or request priority_high Important, but it can wait labels Jul 27, 2020
@tngreene tngreene added this to the XPlaneForExporter alpha.1 milestone Jul 27, 2020
@tngreene
Copy link
Contributor Author

Unit test is part way along, wouldn't take much to finish it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority_high Important, but it can wait
Projects
None yet
Development

No branches or pull requests

1 participant