Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMSD does not seem to be correct #16

Closed
LilySnow opened this issue Feb 20, 2023 · 2 comments
Closed

RMSD does not seem to be correct #16

LilySnow opened this issue Feb 20, 2023 · 2 comments
Assignees

Comments

@LilySnow
Copy link
Contributor

LilySnow commented Feb 20, 2023

The RMSD values from calc_rmsd_with_template() do not seem to be correct… Did you compare with pdb2sql or ProFit on several cases?

Here is my command:

python gradpose.py -i ../../examples/PDBs/ -c M -r 1:180 -n 4 --rmsd --verbose

The rmsd that I got:

Template ../../examples/1AGD_template.pdb
1AGD.pdb 6.817497915769525e-07
1LP9.pdb 16.12244573923463
2H6P.pdb 15.130915326196774
3PWL.pdb 14.935339291532562
4G42.pdb 117.51142120491433
5C0A.pdb 14.87346804143781
5TEZ.pdb 19.270347212921646
6KWN.pdb 24.042137062836726
6ULR.pdb 122.4421570612006
7LG0.pdb 22.45569173016011

Some of these RMSDs are extremely high considering that the resulting structures are very well aligned.

I remember Farzaneh and Jan compared the RMSDs that Kevin calculated with pdb2sql. And they were fine...

@LilySnow
Copy link
Contributor Author

LilySnow commented Feb 22, 2023

After you fix this bug, please add a test about the RMSD calculations

@DTRademaker
Copy link
Collaborator

After investigating further, we found that the issue was caused by using the standardized coordinates of the 3D structures. We have since fixed this issue by using unscaled values, and the RMSD values are now correct. In our paper, we utilized a third-party software for the calculations in order to ensure a fair comparison between different software tools. This is the reason why the issue went unnoticed during our analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants