Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hit modifiers from applying to indirect fire #1216

Merged
merged 1 commit into from Aug 10, 2023

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Jun 29, 2023

Fixes #1213

@Iridar Iridar added bug-basegame ready-to-review A pull request is ready to be reviewed labels Jun 29, 2023
@Iridar Iridar added this to the 1.26.0 milestone Jun 29, 2023
@Iridar Iridar self-assigned this Jun 29, 2023
Copy link
Contributor

@Tedster59 Tedster59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me.

@Iridar
Copy link
Contributor Author

Iridar commented Aug 10, 2023

Just as a sanity check, tested if this still allows Biggest Booms to work, and it does.

@Iridar Iridar added the ready-for-merge the pull request was reviewed and is ready to be merged. label Aug 10, 2023
@Iridar Iridar merged commit 9490789 into X2CommunityCore:master Aug 10, 2023
4 checks passed
@Iridar Iridar deleted the 1213-gurantee-guaranteed-hits branch August 10, 2023 08:58
@Iridar Iridar added reverted and removed ready-to-review A pull request is ready to be reviewed ready-for-merge the pull request was reviewed and is ready to be merged. labels Aug 21, 2023
@Iridar
Copy link
Contributor Author

Iridar commented Aug 21, 2023

This was reverted in 1.26.1 due to breaking certain abilities when used alongside XMB. Alternative approach to be figured out in 1.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bIndirectFire hits aren't guaranteed
3 participants