Integrate Revival Protocol Fixes in CHL #1237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew X2_Condition for Revival Protocol APs
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
f55f062
to
7d07a46
Compare
Iridar
added
bug-basegame
ready-to-review
Iridar
requested changes
Oct 29, 2023
Iridar
added
waiting-on-author
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
5ef8410
to
f4eb689
Compare
…on for granting APs. Updated X2Condition_RevivalProtocol so it can target stunned & resistance units and added 'stunned' to the list of things it can remove. APs granted to stunned units via stunrecover.
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
81b502a
to
6b9b159
Compare
BlackDog86
added
ready-to-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1235 - Adds a new custom X2Condition to the RestoreActionPoints effect of Revival Protocol to prevent it from restoring APs to disoriented units. Updated the ability targetting condition to allow revival protocol to target stunned units, remove the stunned status and restore APs properly. Also integrated the additional targeting condition from RMs mod which allows the ability to target resistance soldiers. Discussion to be had over whether this part is required/necessary. Tested & confirmed working in-game.
May break compatibility with the original mod - requires further testing & documentation.