Fix issue with pillar ability's cover not updating properly on units spawned next to the actor #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDog86
added
bug-basegame
ready-to-review
BlackDog86
changed the title
Iridar
requested changes
Feb 27, 2024
BlackDog86
force-pushed
the
1288-Fix-Pillar
branch
from
b6b2b03
to
912ea6b
Compare
|
Should be done now |
|
Sorry, but it's in the wrong commit now. For PRs that add new files to Highlander, the first commit must have the new file and change to .x2proj file (it helps to restart modbuddy before making the commit so that changes actually apply to the .x2proj file), and the second commit should have the rest of the PR. |
BlackDog86
force-pushed
the
1288-Fix-Pillar
branch
from
912ea6b
to
73b17a0
Compare
BlackDog86
force-pushed
the
1288-Fix-Pillar
branch
from
73b17a0
to
f09371e
Compare
…jacent to the newly created pillar.
|
Commits re-arranged |
BlackDog86
added
waiting-on-author
|
Needs more work - issue was more complex than first thought |
BlackDog86
force-pushed
the
1288-Fix-Pillar
branch
from
290ec94
to
551e15c
Compare
|
In testing this PR doesn't actually fix the issue. The latest commit includes other things I tried, but none of them help either. I'm closing it for now, feel free to reopen later if a solution is found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288