Fix Clippy warnings #132
Merged
Fix Clippy warnings #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicceboy
force-pushed
the
fix-clippy-complaints
branch
from
c776dbd
to
1604959
Compare
|
Thank you for your PR, and congrats on your first contribution! 🎉
Sure as long as aren't overly cumbersome to fix. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Clippy warnings on default configuration.
There seems to be also quite many warnings on pedantic level when checking with
cargo clippy -- -W clippy::pedanticWould it be okay to also attempt to fix some of these?