Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp] All fields are private? #14

Closed
repnop opened this issue Jul 18, 2021 · 1 comment · Fixed by #122 or #128
Closed

[snmp] All fields are private? #14

repnop opened this issue Jul 18, 2021 · 1 comment · Fixed by #122 or #128

Comments

@repnop
Copy link
Contributor

repnop commented Jul 18, 2021

Hi, a friend just linked your 0.3.0 announcement and I'm super excited to see SNMP stuff get a crate! :D However, reading through the docs and then the code, I'm assuming some fields were forgotten to be made pub? e.g. https://github.com/XAMPPRocky/rasn/blob/fb424b886f15d2d3943fffbb72ae0d2fccdf4e7b/standards/snmp/src/v1.rs#L52-L58

There's no way to construct or inspect any Pdu since all fields are private and there's no constructor or accessor methods. Seems like the other structs have similar issues. Haven't looked at the other new crates yet so not sure if its the case there either.

@XAMPPRocky
Copy link
Collaborator

Whoops minor mistake, I'll release a patch with public fields.

This was referenced Jul 11, 2023
This was referenced Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants