Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long form tag decoding #54

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix long form tag decoding #54

merged 1 commit into from
Nov 23, 2021

Conversation

shortbus-rider
Copy link
Contributor

@shortbus-rider shortbus-rider commented Nov 22, 2021 •
edited
Loading

  • change endianness to big
  • change the test to make the first octet nonzero

Fixes #53

@shortbus-rider
Fix long form tag decoding
7dc2723 
* change endianness to big
* change the test to make the first octet nonzero
@shortbus-rider shortbus-rider mentioned this pull request Nov 22, 2021
Closed
@XAMPPRocky
Copy link
Collaborator

XAMPPRocky commented Nov 22, 2021 •
edited
Loading

Ignore the failing check, that's an unrelated regression in Rust.

@XAMPPRocky
Copy link
Collaborator

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 5881984 into librasn:main Nov 23, 2021
@shortbus-rider shortbus-rider deleted the fix_long_form_tag_decoding branch November 23, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix long form tag decoding
2 participants
@shortbus-rider @XAMPPRocky