Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vario gauge units incorrect #305

Closed
thermalling opened this issue Dec 23, 2019 · 3 comments
Closed

Vario gauge units incorrect #305

thermalling opened this issue Dec 23, 2019 · 3 comments
Labels

Comments

@thermalling
Copy link

thermalling commented Dec 23, 2019

When units are set to ft/min, vario gauge shows incorrect readings.
For example, when Vario InfoBox shows 600 ft/min, gauge arrow reads just over 3, and gauge digital Gross reads 99.9 ft/min. Same applies for sink values.
XCSoarVarioGaugeIncorrect
This issue occurs in Version 7.0_preview14
git: e44fe90136 (Compiled 2019-12-23)

and in current 6.8.11 Kobo.
Thanks.
Neil.

@lordfolken lordfolken added the bug label May 4, 2020
@lordfolken
Copy link
Contributor

There are two bitmaps set as background for the vario infobox. To me it seems that the bitmap is not exchanged when you change the lift units at runtime. Once you restart XCSoar it displays correctly. Can you confirm?

@thermalling
Copy link
Author

thermalling commented May 16, 2020

Hi lordfolken.
Thanks very much for looking into this.
I have re-tested. Behaviour is identical after restarting XCSoar.

Test process:

  1. Open XCSoar in SIM mode
  2. Change units to m/s
  3. Test by incrementing altitude using +10 button -> OK per screenshot
    XCSoar_m_sOK
  4. Restart XCSoar -> SIM mode
  5. Change units to ft/min
  6. Test by incrementing altitude using +10 button -> same bug as previously
  7. Restart XCSoar -> SIM mode
  8. Test by incrementing altitude using +10 button -> same bug as previously

A couple of notes:

  • The same bug appears on the Kobo in flight, not SIM.
  • The bitmaps are not the only issue; the number 99.9 ft/min displayed on the gauge should read 600 ft/min, to match the value in the InfoBox.
  • Something for later: On m/s, the gauge bitmap is not quite accurate, showing just over the expected 3m/s. This one is much less urgent.

Thanks again, and please let me know if I can help.

@MaxKellermann
Copy link
Contributor

The bitmap is only reloaded after restarting XCSoar.
And there are only two background images: one for m/s and one for knots. I have no idea who in their right mind would use knots for vertical speeds, but that's what XCSoar's original developers implemented.
So there's no image for ft/min, so XCSoar does "something".

@lordfolken lordfolken added this to the v7.6 milestone Apr 8, 2021
@lordfolken lordfolken removed this from the v7.6 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants