Untranslated strings on splash screen / prompt window

[scls19fr]

XCSoar versions having and not having the problem

XCSoar 7.6

Expected behavior

Strings on splash screen should be translated.

"Quit" button
"What do you want to do?"

Actual behavior

Steps to reproduce the behavior

1. Set language to a non english language (Config / System / Look / Language, Input).
2. Quit XCSoar
3. Run XCSoar

Do you have any idea what may have caused this?

XCSoar/src/Dialogs/SimulatorPromptWindow.cpp

Line 112 in 464df29

canvas.DrawText(label_position, _("What do you want to do?"));

uses _ macro not N_ macro

same for

XCSoar/src/Dialogs/SimulatorPromptWindow.cpp

Line 60 in 464df29

quit_button.Create(*this, look.button, _("Quit"), rc, style,

Do you have an idea how to solve the issue?

Using N_ macro instead.

But such changes may not be enough (because I don't know XCSoar startup process enough)

[MaxKellermann]

When that screen is displayed, XCSoar hasn't loaded any profile yet. Without a profile, your profile's language configuration is not set.

[scls19fr]

Maybe profile should be loaded before this page is shown?

[MaxKellermann]

Which profile? Profile selection comes after that.

[scls19fr]

I didn't saw any option to choose a specific profile because I was only using default profile. Maybe choosing profile should simply be done before showing this page.
An other option could be to use default system language until profile is not loaded

[lordfolken]

XCSoar uses the system locale to define a language on initial start. So we could also use this to change the start screen. If the user then loads a different language in his profile, that's a conscious choice on his behalf.