Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superruns don't work with event_info_double #605

Closed
jjakob03 opened this issue Jul 30, 2021 · 2 comments
Closed

Superruns don't work with event_info_double #605

jjakob03 opened this issue Jul 30, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jjakob03
Copy link
Contributor

Describe the bug
After creating a superrun in straxen, loading it with event_info works fine. Loading it with event_info_double as a target gives an error: RuntimeError: Could not load event_info_double for subrun 024418 even though we made it??

To Reproduce
Insert the MWE of how to reproduce the error

import cutax
st = cutax.xenonnt_v3()
superrun_name = '_some_KrRuns'
subrun_ids = ['024425', '024423', '024421', '024418']
st.define_run(superrun_name, data=subrun_ids)

df1 = st.get_df('_some_KrRuns', targets='event_info')

df2 = st.get_df('_some_KrRuns', targets='event_info_double')

Expected behavior
I would expect two dataframes containing the runs in the two different plugins.

Versions

Working on dali001.rcc.local with the following versions and installation paths:
python	v3.8.10	(default, Jun  4 2021, 15:09:15) [GCC 7.5.0]
strax	v0.16.1	/opt/XENONnT/anaconda/envs/XENONnT_development/lib/python3.8/site-packages/strax
straxen	v0.19.3	/opt/XENONnT/anaconda/envs/XENONnT_development/lib/python3.8/site-packages/straxen
cutax	v0.1.1	/home/jjakob/.local/lib/python3.8/site-packages/cutax
@jjakob03 jjakob03 added the bug Something isn't working label Jul 30, 2021
@JoranAngevaare
Copy link
Contributor

Looks like strax.SaveWhen.NEVER plugins aren't changed to saving when defining the super-run.

It would indeed be intuitive if this is done behind the scenes. To see that this is the underlying issue you can see that this small adaptation would work):

import cutax
import strax
st = cutax.xenonnt_v3()
superrun_name = '_some_KrRuns_saved'
subrun_ids = ['024425', '024423', '024421', '024418']
st.define_run(superrun_name, data=subrun_ids)

# Temp change the saving behavoir
st._plugin_class_registry['event_info_double'].save_when = strax.SaveWhen.ALWAYS

df1 = st.get_df(superrun_name, targets='event_info')

df2 = st.get_df(superrun_name, targets='event_info_double')

@WenzDaniel
Copy link
Collaborator

Solved with AxFoundation/strax#509 and #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants