Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Future Improvement] Updating Recruit Officers #250

Open
16 tasks
BeReal86 opened this issue Oct 15, 2019 · 8 comments
Open
16 tasks

[Future Improvement] Updating Recruit Officers #250

BeReal86 opened this issue Oct 15, 2019 · 8 comments
Assignees
Labels
Feature Issues that will become new features

Comments

@BeReal86
Copy link
Member

BeReal86 commented Oct 15, 2019

Commander

  • +40 favourites
    With more favourites you can save more messages, which can then alse be shared.
  • Building queue
    Place up 4 additional building contracts at the same time in the building queue.
  • Transport scanner
    The number of resources that the transporter is bringing to your planet will be shown.
  • Advertisement free
    You no longer see advertising for other games, instead only ads about Ogame-specific events and offer will be shown.

Admiral

  • Max. fleet slots +2
    You can dispatch more fleets at the same time.
  • Max. expeditions +1
    You can dispatch one additional expedition at the same time.
  • Improved fleet escape rate
    Until you reach 500.000 points, your fleet is able to retreat when forces are three times bigger than you own.

Engineer

  • Halves losses to defence systems
    After a battle, half of all lost defence systems will be rebuilt.
  • +10% energy production
    Your power stations and solar satellites produce 10% more energy.

Geologist

  • +10% mine production
    Your mines produce 10% more.

Technocrat

  • +2 espionage levels
    2 levels will be added to your espionage research.
  • 25% less research time
    Yours research requires 25% less time till completion.

When all recruitment officers are active, the following bonus officer is active.

Commanding Staff

  • Max. fleet slots +1
    You can dispatch more fleets at the same time.
  • +2% energy production
    Your power stations and solar satellites produce 2% more energy.
  • +2% mine production
    Your mines produce 2% more.
  • +1 espionage levels
    1 levels will be added to your espionage research.

officers

Screenshot_5

Screenshot_7

resim

@BeReal86 BeReal86 added the Enhancement Issues that require improvements label Oct 15, 2019
@jonamix-ar
Copy link

*Halves losses to defence systems
This is before with the old battle engine with the new jstar engine that does not exist

@LucasKovacs LucasKovacs added this to the v3.2.0 milestone Oct 18, 2019
@BeReal86 BeReal86 modified the milestones: v3.2.0, v3.3.0, v3.5.0, v3.4.0 Nov 1, 2019
@LucasKovacs LucasKovacs self-assigned this Nov 8, 2019
@BeReal86 BeReal86 self-assigned this Aug 22, 2020
@LucasKovacs LucasKovacs removed this from the v3.5.0 milestone Oct 31, 2020
@jonamix-ar
Copy link

Dejo esto por acá para que no tengan problemas con el CP me atreví de cambiar el comandante por la estrella.
allOfficers_ikon
allOfficers

@jonamix-ar
Copy link

jonamix-ar commented Dec 29, 2021

El max Expedition

fleet1.php
'max_expeditions' => FleetsLib::getMaxExpeditions( $this->_research->getCurrentResearch()->getResearchAstrophysics(), $this->_premium->getCurrentPremium()->getPremiumOfficierAdmiral() ),

fleetLib.php
public static function getMaxExpeditions($astrophysics_tech, $amiral_level) { return floor(sqrt($astrophysics_tech) + (1 * (OfficiersLib::isOfficierActive($amiral_level) ? AMIRAL_EXPEDITION : 0))); }

fleet1_view.php

<tr>
                        <td style="background-color: transparent;">
                            {fl_fleets} {fleets}/{max_fleets}
                            &nbsp;
                            {amiral_bonuses}
                            &nbsp; {fl_expeditions} {expeditions}/{max_expeditions}
                        </td>
                        <td style="background-color: transparent;text-align: right!important;">
                            <a href="game.php?page=movement">{fl_fleets_movements}</a>
                        </td>
                    </tr>

nuevo archivo
fleet1_amiral_row.php

<a href="game.php?page=officier" alt="{of_admiral}" onmouseover="return overlib('<table width=275px><tr><th style=text-align:left>{fl_amiral_bonuses}</th></tr></table>');" onmouseout="return nd();" style="vertical-align: middle;"> <img src="{dpath}premium/admiral_ikon.gif" width="20" height="20"> </a>

Fleet1.php

private function buildNoAmiralBlock($amiral)
    {
        if ($amiral) {
            return $this->template->set('fleet/fleet1_amiral_row', array_merge($this->langs->language, ['dpath' => DPATH]));
        }
    }

Lang / Spanish
'fl_amiral_bonuses' => '+ 2 Espacios disponibles debido a Almirante',

Lang / English
'fl_amiral_bonuses' => '+ 2 Fleet slots because of Admiral',

Constants.php

define('AMIRAL_EXPEDITION', 1);

Creo q no me olvide nada

Con Almirante
image

Sin Almirante
image

Fix movimiento de flotas

movement.php

'max_expeditions' => FleetsLib::getMaxExpeditions(
                $this->research->getCurrentResearch()->getResearchAstrophysics(),
                $this->premium->getCurrentPremium()->getPremiumOfficierAdmiral()
            )

@LucasKovacs
Copy link
Member

@FGServers tenes que aprender a hacer PRs…. Esto de copiar/pegar es muy aburrido… cual es el propósito además de los pop ups?

@jonamix-ar
Copy link

ual es el propósito además de los pop

use overlib por que no tiene implementado un tooltip. es como esta en ogame como para hacerlo lo mas parecido al rediseño con el antiguo diseño jajaja ya voy aprender hacer PR

@LucasKovacs LucasKovacs added Feature Issues that will become new features and removed Enhancement Issues that require improvements labels Jan 5, 2022
@BeReal86
Copy link
Member Author

#532

Update; Officers no longer need to be active for the MAX button.

@jonamix-ar
Copy link

jonamix-ar commented Apr 24, 2023

Update Officers
El equipo comando es un bonus extra que suma cuando tenes activos todos los oficiales. que es lo que hace cuando vos tenes todos los oficiales activos te agrega 4 bonus más extras.

Bonus:

Cantidad de flotas máx. +1
+2 % de producción de energía
+2 % de producción de mineral
+1 al nivel de espionaje
+5 días de vacaciones

image

Dejo la imagen modificaa por que la original es de ogame, cuando lo activas
image

Le suma a los oficiales los dias que contratas el bonus extra
image
image
image

@BeReal86
Copy link
Member Author

resim

resim

One is the image I got from ogame.us the other ogame test universe. Bonuses are 4 and have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issues that will become new features
Projects
Status: No status
Development

No branches or pull requests

3 participants