Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.0] Fuel consumption within capacity #410

Closed
BeReal86 opened this issue Oct 31, 2020 · 11 comments
Closed

[3.2.0] Fuel consumption within capacity #410

BeReal86 opened this issue Oct 31, 2020 · 11 comments
Assignees
Labels
Done Issues that were labeled as a task, feature or enhancement Enhancement Issues that require improvements
Milestone

Comments

@BeReal86
Copy link
Member

In the original ogame, fuel consumption was excluded from capacity. As seen in XGP, fuel consumption is deducted from cargo capacity.

Screenshot_17

Screenshot_18

Screenshot_19

Screenshot_20

@jonamix-ar
Copy link

Puede que sea un bug visual de OGame.

@BeReal86 BeReal86 added this to the v3.2.0 milestone Nov 2, 2020
@BeReal86 BeReal86 added the Bug Issues that is an error, bug or it is not working as expected label Nov 3, 2020
@LucasKovacs LucasKovacs removed this from the v3.2.0 milestone Nov 3, 2020
@duhow
Copy link
Contributor

duhow commented Nov 16, 2020

Looks like this is intended? It can be removed.

$this->_fleet_storage -= $consumption;

@LucasKovacs
Copy link
Member

@duhow it needs more test. There are some JS also that takes care of it

@LucasKovacs LucasKovacs added this to the v3.3.0 milestone Nov 23, 2020
@jonamix-ar
Copy link

image
Indeed, more testing is needed with ogame x1 because in ogame 8.5.0 they solved the bug of deuterium consumption that ships can transport

@LucasKovacs
Copy link
Member

So what’s the conclusion? Does the fuel takes storage capacity or not?

@jonamix-ar
Copy link

jonamix-ar commented Dec 27, 2021

‎Entonces, ¿cuál es la conclusión? ¿El combustible toma capacidad de almacenamiento o no?‎

I did not test it because now gonzalo is seeing that but because of what he told me that now it occupies part of the storage space to transfer the mission fuel

In the test universe of ogame it works like this

image

@LucasKovacs
Copy link
Member

Ok so fuel is not part of the storage

@jonamix-ar
Copy link

jonamix-ar commented Jan 1, 2022

Ok so fuel is not part of the storage

From what is seen in OGame it does not affect the storage of resources. and it's weird it should. it used to be like that

@LucasKovacs LucasKovacs modified the milestones: v3.3.0, v3.4.0 Apr 14, 2023
@LucasKovacs
Copy link
Member

@FGServers / @BeReal86 currently does deuterium take space from cargo capacity? I want to implement this one, but I need to be sure

@BeReal86
Copy link
Member Author

BeReal86 commented Apr 24, 2023

resim

resim

@LucasKovacs Yes, I did a little experiment again. Deuterium doesn't take up space from cargo capacity.

@LucasKovacs LucasKovacs added Enhancement Issues that require improvements Done Issues that were labeled as a task, feature or enhancement and removed Bug Issues that is an error, bug or it is not working as expected labels Apr 25, 2023
@LucasKovacs
Copy link
Member

LucasKovacs commented Apr 25, 2023

Completed as part of commit#f7cf381e3d2d3cb800ae635b2605981ad58ee376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Issues that were labeled as a task, feature or enhancement Enhancement Issues that require improvements
Projects
Status: Done
Development

No branches or pull requests

4 participants