Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light: Color modes #698

Closed
3 of 10 tasks
farmio opened this issue May 18, 2021 · 3 comments
Closed
3 of 10 tasks

Light: Color modes #698

farmio opened this issue May 18, 2021 · 3 comments
Labels

Comments

@farmio
Copy link
Member

farmio commented May 18, 2021

  • add support for yxY color mode - DPT242.600 (6byte)
  • add HS-color individual address support
  • move encoding/decoding of RGB and RGBW payloads to DPT module
  • RGBW currently accepts 4-6 bytes payload. The DPT specifies 6bytes. I think we may not accept 4 and 5 bytes for this.

  • add RemoteValueColor module using one of these 3 dpts.
  • use a color-mode attribute to select used dpt instead of group addresses for each mode (RGB, RGBW, XY)
    this would prevent support for multiple modes for one light (which is currently not implemented)
  • maybe add auto sense dpt option for color temperature based on payload length
    for RGB, RGBW - XY has the same payload length as RGBW so this would collide~

  • use a color_temperature-mode attribute to select used dpt instead of group addresses for each mode (CT, TW)
  • add auto sense dpt option for color temperature based on payload length

  • Debounce callbacks for individual color statues. Now each telegram creates one device_updated callback causing the displayed color in HA to flicker.
This was referenced Jul 25, 2021
@crazyfx1
Copy link
Contributor

crazyfx1 commented Oct 1, 2021

use a color_temperature-mode attribute to select used dpt instead of group addresses for each mode (CT, TW)

Is this still something you want to have implemented? I could do that in the next weeks ;)

@farmio
Copy link
Member Author

farmio commented Oct 1, 2021

@crazyfx1 this is just a collection of ideas I had when I started to change something in the light module.
If you think this change is useful, go for it 👍. I'm fine with the current implementation too, but a combined address would allow to

add auto sense dpt option for color temperature based on payload length

HA already uses a combined address and a mode option.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please make sure to update to the latest version of xknx (or Home Assistant) and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants