Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Waiting Contents #637

Closed
GregMage opened this issue Feb 7, 2019 · 3 comments · Fixed by #994
Closed

Block Waiting Contents #637

GregMage opened this issue Feb 7, 2019 · 3 comments · Fixed by #994

Comments

@GregMage
Copy link
Contributor

GregMage commented Feb 7, 2019

in XoopsCore25\htdocs\modules\system\blocks\system_blocks.php:

// this block is deprecated
b_system_waiting_show()

It misses a message that says this block is deprecated when using this block

I find it unfortunate to depreciate this block because it is very convenient!

I think that we should review the code to add a module without changing the system module (I think a system identical to the search system).

What do you think?

@geekwright
Copy link
Contributor

That has been marked deprecated for a long time (I stopped looking after finding that in XOOPS 2.5.4.)

In 2.6 there is the waiting module which implements a plugin interface that any module can implement. There may be some changes to the details, but that is the future direction.

For 2.5, I've used GIJ-CHECKMATE Extensible Waiting Block Module which also uses a plugin system.
http://xoops.peak.ne.jp/md/mydownloads/singlefile.php?lid=38

It is older code, but I have made a few unpublished changes to support recent upgrades to some existing sites. Let me know if it would be of any use to you.

@GregMage
Copy link
Contributor Author

GregMage commented Feb 8, 2019

I will create a block directly in my module for that. I look forward to version 2.6 which will simplify things.

@mambax7 mambax7 added this to To do in XOOPS 2.5.x Oct 7, 2019
@GregMage
Copy link
Contributor Author

looking for an answer for #989

I remembered the problem of this block!

Can we put a deprecated message? Or even remove that unnecessary block?

XOOPS 2.5.x automation moved this from To do to Done Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
XOOPS 2.5.x
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants