Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See sales history of a particular monster (template) instead of just history of asset #95

Open
cryptotester opened this issue Mar 31, 2021 · 1 comment

Comments

@cryptotester
Copy link
Contributor

See here. Right now when you browse to an asset, e.g. Dullahan, you see by default only the history of the cheaper offer, like in this case the id 86 being sold for 1.5M.

image

It would be nice to have a way to see the history of all Dullahan serial numbers. In fact this would make more sense to me, so to understand market prices etc. I mean I'd be very curious to see what where the selling prices before reaching 1.5M. The majority of them is not listed for sale, but it would be cool ti see that history too.

I'd do like this, change the actual history and show the history of all serial numbers (asset_ids, actually) belonging to that template.

Then I'd add a switch button called like "only this serial history" that if clicked, would filter the history and show only the selected asset. So e.g. when clicking a different serial number from the dropdown I'd still show the global history. When the switch button clicked: show only that serial nr. If clicked again, show again the global history. If clicked (filtered by serial) and clicked a new serial nr from the dropdown, like now, show the history filtered by that asset.

What do you think?

@cryptotester
Copy link
Contributor Author

Oh I see you added this to the official marketplace:

https://dev.protonmarket.com/monsters/1

image

Can you consider adding just this little modification in the nft-demo ? I mean it's just a tab showing the global ales and you have the query for the global sales already. Would be cool. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant