Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and updates on es.json #40

Closed
wants to merge 1 commit into from
Closed

Conversation

macorv
Copy link

@macorv macorv commented Oct 4, 2020

Hi! Made some fixes and updates on the file (see below for details).

My name is Martin and I am from Argentina. My native language is spanish. My country is under high inflation and find Xumm an useful tool to fight against it, keeping my life savings safe. I think that helping translating the amazing work you have done creating Xumm will spread the app to more people here in Argentina and in LatAm. Hope you find my contribution helpful! Best regards, Martin.

Summary:

  • Saw that the majority of sentences were written in 3rd person, so I changed some sentences that were in 2nd person to 3rd person.
  • Fixed some bad/literal translations. e.g.: line 7 'back' was translated as 'espalda' (that in spanish means a person's back).
  • Improved meaning and context of some sentences.
  • Line 34: 'exchanges'. Noticed that is used in IOU's screen (Add Asset) to describe the issuers of the Assets. I think it's more familiar for spanish speakers to refer to them as 'emisores' (=issuers) rather than Exchanges. In this particular case, it happen to be both: issuers and exchanges (except Towo Labs). So, my proposal is to call them 'Emisores' in the spanish translation because it's more suitable to describe what those 'entities/parties' do with the assets listed.

Hi! Made some fixes and updates on the file (see below for details). My name is Martin and I am from Argentina. My native language is spanish. My country is under high inflation and find Xumm an useful tool to fight against it, keeping my life savings safe. I think that helping translating the amazing work you have done creating Xumm will spread the app to more people here in Argentina and in LatAm. Hope you find my contribution helpful! Best regards, Martin.

- Saw that the majority of sentences were written in 3rd person, so I changed some sentences that were in 2nd person to 3rd person.
- Fixed some bad/literal translations. e.g.: line 7 'back' was translated as 'espalda' (that in spanish means a person's back).
- Improved meaning and context of some sentences.
- Line 34: 'exchanges'. Noticed that is used in IOU's screen (Add Asset) to describe the issuers of the Assets. I think it's more familiar for spanish speakers to refer to them as 'emisores' (=issuers) rather than Exchanges. In this particular case, it happen to be both: issuers and exchanges (except Towo Labs). So, my proposal is to call them 'Emisores' in the spanish translation because it's more suitable to describe what those 'entities/parties' do with the assets listed.
@WietseWind
Copy link
Member

Thank you! We're going to add translations in V1 of the app, later this year. We really appreciate this!

@macorv
Copy link
Author

macorv commented Oct 5, 2020

Great! Thank you and the team for the app!

@WietseWind WietseWind added Translations Text changes (typo, etc.) In progress We're working on this labels Nov 12, 2020
@WietseWind
Copy link
Member

Hey @macorv!

We didn't forget about this :) We just imported your entire translation into the XUMM Translation Portal. We're finishing developing the portal as we speak. The portal offer some nice features like:

The day we launch Translation Portal (about two weeks from now) your contribution will be available for others to vote, complement and of course for you to modify, if you feel like it.

Thank you!! ❤️

@WietseWind WietseWind closed this Nov 13, 2020
@macorv
Copy link
Author

macorv commented Nov 14, 2020

Thank you Wietse!
Great work on the Translation Portal! When will it go live?

@WietseWind
Copy link
Member

~ 2 weeks. But if you want early access: drop me a message at hi at wietse.com

@macorv
Copy link
Author

macorv commented Nov 23, 2020

Thanks, Wietse! Drop a Hi at Twitter (The Translation Portal Thread).

@WietseWind
Copy link
Member

WietseWind commented Nov 27, 2020

https://twitter.com/WietseWind/status/1332128319039561728 🚀

Please note that, while I imported your existing translations to the portal, the translation portal uses your XRPL account you can use to sign in to the portal as the unique user identifier.

To prevent you from having to review your own translations, send me a message when you're in (using the support chat button in the Translation portal) with your Github username and used r-account address (to sign in to the portal) so I can migrate the imported translations, and link them to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In progress We're working on this Translations Text changes (typo, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants