Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show/enter converted values from (most) fiat currencies from/to XRP (backend price feed) #257

Closed
WietseWind opened this issue Sep 2, 2020 · 1 comment
Assignees
Labels
API / Backend xumm.app/api & App Backend App iOS/Android App Improvement TODO XRPL Backlog

Comments

@WietseWind
Copy link
Member

WietseWind commented Sep 2, 2020

dd XRP balance local Currency Conversion:

  • API Endpoint (@WietseWind)

  • Settings: set preferred local currency

  • Home screen: tap/ swipe left/right on XRP + balance to switch between XRP / currency view

  • Send flow: when entering non IOU (XRP) amount: allow entering in currency & convert (show) XRP

  • Sign Request: if payment & if non IOU: show both XRP and local currency ~ estimate.

  • TX Details screen: if Payment (in/out) and if non IOU (XRP) show the current fiat ~ estimate.

  • Request button (also for Read Only accounts, 'Show QR code') panel: Share & Copy address button next to each other ('pill', attached?) and add a button: "Request with amount". Allow amount entry, toggle between XRP and configured fiat currency (just like at the Amount in Send Flow), convert to XRP (just like in Send Flow) and then show a QR with the destination + amount prefilled:
    https://xumm.app/detect/request:{myAccount}&amount={amountInXrp}

@thisistriss For you to take a look at:

  • Send flow + Request:
    How are we going to allow a user to toggle (to enter an amount, when currency to send selected = XRP) between enter in XRP (to send XRP) or enter in local currency - A toggle under / above the amount field? A popout/option when focussing in the amount field, where users must select what they want to enter first? ..

Edit:
In the send screen having two input for XRP and Selected currency

3224021B-8A2E-4A33-8243-C760EE33361A

@WietseWind WietseWind added API / Backend xumm.app/api & App Backend App iOS/Android App TODO XRPL Backlog Improvement labels Sep 2, 2020
@WietseWind WietseWind added this to Next sprint (0.7.0) in XUMM 0.X, 1.X & 2.1 Sep 2, 2020
@canny
Copy link

canny bot commented Sep 2, 2020

@WietseWind WietseWind moved this from Backlog: next sprint (?) to Pre 1.0.0 backlog in XUMM 0.X, 1.X & 2.1 Jan 4, 2021
@WietseWind WietseWind moved this from Pre 1.0.0 backlog to 1.X.X in XUMM 0.X, 1.X & 2.1 Jan 21, 2021
@WietseWind WietseWind changed the title [Improvement] Add convert XRP from Fiat values when sending/requesting [Feature] Show/enter converted values from (most) fiat currencies from/to XRP (backend price feed) Jan 22, 2021
@WietseWind WietseWind moved this from 1.X.X to 1.1.0 in XUMM 0.X, 1.X & 2.1 Jan 22, 2021
@XRPL-Labs XRPL-Labs deleted a comment from canny bot Jan 22, 2021
@XRPL-Labs XRPL-Labs deleted a comment from canny bot Jan 22, 2021
@XRPL-Labs XRPL-Labs deleted a comment from canny bot Jan 22, 2021
@XRPL-Labs XRPL-Labs deleted a comment from canny bot Jan 22, 2021
@N3TC4T N3TC4T moved this from 1.1.0 to Done, test (1.X.X) in XUMM 0.X, 1.X & 2.1 Feb 1, 2021
@WietseWind WietseWind moved this from Done, test (1.X.X) to Tested, Ready for 1.1.0 release in XUMM 0.X, 1.X & 2.1 Apr 13, 2021
@WietseWind WietseWind reopened this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / Backend xumm.app/api & App Backend App iOS/Android App Improvement TODO XRPL Backlog
Projects
XUMM 0.X, 1.X & 2.1
  
Released (V2, 2.0.0)
Development

No branches or pull requests

3 participants